Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add these famous icons of gen9 (Scarlet&Violet) #131

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

danimesq
Copy link

@danimesq danimesq commented Jan 6, 2024

No description provided.

@danimesq
Copy link
Author

danimesq commented Jan 6, 2024

@FallenDeity, what do you think about this?

@FallenDeity
Copy link
Contributor

There are a few issues here you are not following the sprite conventions here

  • all sprites are mapped to their respective pokemon id like (Bulbasaur to 1.png) this mapping is used to generate the api data
  • The Big sprites are pretty redundant in my opinion and has no such precedent in the repository before the Small sprites seem fine
  • There seems to be a ton of white space around the icons those could perhaps be trimmed to compress the pngs and have a smaller size overall while maintaining aspect ratio (square)
  • There also seems to be a missing female directory for female icons the previous version icons included this.

That should be about it I suppose, lmk if you need any help 😄.

Also btw I am just a contributor don't have much power on which pr is accepted you might want to request @Naramsim or one of the other maintainers also for approval regarding the final PR.

@Naramsim
Copy link
Member

Naramsim commented Jan 8, 2024

Hi! I cannot really review this PR since it's too large. By reading the comment of @FallenDeity I think the same way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants