Objects may be retained through map connections #959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vulcandth
force-pushed
the
resolve-connection-obj-flicker
branch
from
1e64c5c
to
d23b33a
Compare
Rangi42
reviewed
May 19, 2024
Rangi42
reviewed
May 19, 2024
Rangi42
reviewed
May 19, 2024
Rangi42
reviewed
May 19, 2024
Rangi42
reviewed
May 19, 2024
If an object's xy coordinates relative to the player's matches a new mapobject's xy coordinates relative to the player, then than object will be retained/reassociated with the new mapobject.
vulcandth
force-pushed
the
resolve-connection-obj-flicker
branch
from
d23b33a
to
d5aca5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an object's xy coordinates relative to the player's matches a new mapobject's xy coordinates relative to the player, and their sprite matches, then than object will be retained/reassociated with the new mapobject.
This resolves the issue of object reshuffling when crossing map connections; particularly the cut tree flicker on route32.