Finalized cleaned code for Polybius Java 2018 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- IDConfig now has IDs for left and right joysticks on the xbox controller - TypeToggleArcade and TypToggleTank are both commands for being run by button presses to change the drivetrain type to their respective drivetrain - ButtonSelection.java is like IDConfig but for buttons. There are hashtables for each mode for both buttons and doubles. These hashtables store the actual definition of the buttons and the binding of them to the IDs from IDConfig. - OI.java no-longer does any of the definition of buttons, only uses them - OI.java has extra logic now to use an enums to define buttons using ButtonSelection based off of the button map selection enum. - OI.java has extra logic now for selecting drivetrain axes based off both the maping mode and the selected drivetrain mode - A lot of formatting changes/cleanup to affected files
- Major overhaul on formatting and general cleaning of code across the whole project. - Used WPILib upgrade to upgrade project from an Eclipse project to a VSCode project. This is bound to cause some issues. The version of the robot code in this commit is non-functional currently (theres a lot of bugs).
Swapped some usages of TalonSRX from CTRE to PWMTalonSRX. This required some re-configuring on how encoders are configured since the pathfinder configureEncoder method only takes int, int, double parameters. The encoder position is now obtained using .getPosition() instead of .getSelectedSensorPosition(0). This requires rounding of the position (in order to provide the int parameter for the configureEncoder() method) and may result in loss in accuracy. Be sure to test this later
- Added newer versions of CTRE libraries to jars, updated build.gradle to use these new versions. - Continued upgrading/removing deprecated code. - Fixed a lot of errors (mostly from incorrectly trying to use old libraries)
Lift.java was missing some imports for ctre motor control classes.
moving to a different pc, gotta push my WIP stuff
This might fix library issue. The thing I was using, compile files, typically implies multiple files are being compiled as parameters of it.... Whoops
this was done with a standalone rio. no promises it actually works and maintains robotcode on a real robot, I cant test it until Monday.
Not sure if this is important
This reverts commit f88d310.
Our Java branch is fully ported to Gradle!
- Joysticks were inverted bc I forgot a - sign when mappiing them to the drivetrain. Fixed. - Fixed drivetrain accidental inversion of right drive master motor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.