Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement 'sf::Event::visit' #3015

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vittorioromeo
Copy link
Member

See #3014.

@ChrisThrasher
Copy link
Member

In the original event API there was significant pushback to there being more than one way to process events. Have we moved past that?

@vittorioromeo
Copy link
Member Author

In the original event API there was significant pushback to there being more than one way to process events. Have we moved past that?

My personal gripe was having both a switch-based interface and one based on types, because it created duplication of sf::Event::TYPE and sf::Event::Type::TYPE and provided two ways of achieving the same imperative sort of checking.

I don't have a problem with supporting visitation as it is a type-based interface which is compatible with our new event handling model.

@coveralls
Copy link
Collaborator

coveralls commented May 15, 2024

Pull Request Test Coverage Report for Build 9150957514

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 55.571%

Totals Coverage Status
Change from base Build 9150167137: 0.006%
Covered Lines: 11482
Relevant Lines: 19549

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Discussion
Development

Successfully merging this pull request may close these issues.

None yet

3 participants