-
-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regif update #323
base: dev
Are you sure you want to change the base?
Regif update #323
Conversation
@c-thaler good job, |
Idealy, both BusSlaveFactory and RegIf woiuld be merged into a single thing ^^ So maybe the best would be : |
MemoryMappedSlaveFactory is a good description for what it does. Maybe MMSlaveFactory? I'm not sure if everybody interprets MM as "MemoryMapped". At least it also appears in "AvalonMM" :D
Ok. I think that most of the BusSlaveFactory interface can be implemented as a kind of convenience methods in RegIf. So you don't have to deal with "regs" and "fields" which are the building blocks in RegIf. |
Hi ^^ Aren't those conflict weird ? |
Hmmm, I did not touch most of these files :D However, I'm working on an integration of RegIf and Bus Slave Factory. Thus, we can postpone the merge until I'm finished and then merge the whole thing. |
@c-thaler Ok good :D |
@c-thaler I know I'm a bit late to the party, but my 0.02€ from using the regif stuff (just regarding the generators, not the other stuff): I'm not sure whether the visitor like here it the best solution: In Java I'd understand, but scala has the match/case construct for pretty much exactly the use-case you'd do the visitor + double-dispatch in Java. What are your thoughts on that? I'd be happy to remove all the other stuff that is present on my branch and open a PR depending on that. Regarding visitor & scala: https://stackoverflow.com/questions/8618082/visitor-pattern-in-scala |
I decoupled the doc generation from the BusIf structure to make it easier for users to implement their own generators. They can now simply implement a BusIfVisitor.
I also ported the CHeader and HTML generation to BusIfVisitor generators and added a JSON generator.
Regif now also supports Axi4-Lite bus.
Furthermore, I added an event signal for read/write (eventR/eventW).