Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

follow-up for c6c5a5a18695ab5f0be1f68bbb63bf90f6f15657 #6265

Merged
merged 3 commits into from
May 16, 2024

Conversation

f41gh7
Copy link
Contributor

@f41gh7 f41gh7 commented May 13, 2024

  • adds datadog extensions for statsd:

    • multiple packed values (v1.1)
    • additional types distribution, histogram
  • adds type check and append metric type to the labels with special tag name __statsd_metric_type__. It simplifies streaming aggregation config.

  • updates docs

adds datadog extensions for statsd:
- multiple packed values (v1.1)
- additional types distribution, histogram

adds type check and append metric type to the labels with special tag
name `__statsd_metric_type__`. It simplifies streaming aggregation
config.

check for end of tags array, previously it may have incorrect tag values
at the end of array
Copy link
Contributor

@AndrewChubatiuk AndrewChubatiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/README.md Show resolved Hide resolved
docs/README.md Outdated Show resolved Hide resolved
app/vmagent/main.go Outdated Show resolved Hide resolved
docs/README.md Outdated Show resolved Hide resolved
lib/protoparser/statsd/parser.go Outdated Show resolved Hide resolved
lib/protoparser/statsd/parser.go Show resolved Hide resolved
@f41gh7 f41gh7 requested a review from hagen1778 May 15, 2024 13:11
Signed-off-by: hagen1778 <roman@victoriametrics.com>
Copy link
Collaborator

@hagen1778 hagen1778 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hagen1778 hagen1778 merged commit b2765c4 into master May 16, 2024
8 checks passed
@hagen1778 hagen1778 deleted the statsd-follow-up branch May 16, 2024 07:25
@hagen1778
Copy link
Collaborator

@f41gh7 please see doc changes here 54cfb6e

hagen1778 added a commit that referenced this pull request May 17, 2024
* adds datadog extensions for statsd:
  - multiple packed values (v1.1)
  - additional types distribution, histogram

* adds type check and append metric type to the labels with special tag
name `__statsd_metric_type__`. It simplifies streaming aggregation
config.

* remove statsd support from cluster, since cluster doesn't support
stream aggregation.

---------

Signed-off-by: hagen1778 <roman@victoriametrics.com>
Co-authored-by: hagen1778 <roman@victoriametrics.com>

(cherry picked from commit b2765c4)
Signed-off-by: hagen1778 <roman@victoriametrics.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants