app/vmagent: added global aggregator #6268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewChubatiuk
force-pushed
the
aggregators-global
branch
4 times, most recently
from
83e72d9
to
26e09dc
Compare
hagen1778
reviewed
May 15, 2024
| @@ -491,13 +479,28 @@ func tryPush(at *auth.Token, wr *prompbmarshal.WriteRequest, forceDropSamplesOnF | |||
| } | |||
| sortLabelsIfNeeded(tssBlock) | |||
| tssBlock = limitSeriesCardinality(tssBlock) | |||
| sas := sasGlobal.Load() | |||
There was a problem hiding this comment.
Should we retrieve sas before for len(tss) > 0 { on L:448?
yes, tested it and there was a significant difference in resource usage |
AndrewChubatiuk
force-pushed
the
aggregators-global
branch
6 times, most recently
from
39caea2
to
0dfb022
Compare
AndrewChubatiuk
force-pushed
the
aggregators-global
branch
from
0dfb022
to
a3b6974
Compare
* clarify the deprecation note in Changelog * explain the purpose of the stream aggregation change in Changelog * remove mentions of `global` aggregation from docs. Use it as usual and per-url aggregation in wording, so it comes as default aggregation option (wide case) and then user can apply it per-url (narrow case) * add #Routing section to stream aggregation docs * update vmagent's list of flags Signed-off-by: hagen1778 <roman@victoriametrics.com>
|
@AndrewChubatiuk please see changes at 8fac4a6 |
yes, let's merge it |
hagen1778
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
Added global stream aggregation for VMAgent
Checklist
The following checks are mandatory: