Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In Contributing, correct Gitter & mention subreddit #2136

Merged
merged 4 commits into from
May 24, 2024

Conversation

sohang3112
Copy link
Contributor

@sohang3112 sohang3112 commented Mar 14, 2024

Fixes Issue 2131

@sohang3112
Copy link
Contributor Author

@keikoro Please review & merge this PR - Gitter link in CONTRIBUTING.md is corrected, there are no code changes.

@sohang3112
Copy link
Contributor Author

@keikoro Please merge this PR

@keikoro
Copy link
Collaborator

keikoro commented Apr 23, 2024

@sohang3112 Adding the Reddit link is a nice thought, but I'm not aware that any of us admins – except for Zulko – ever looked at the sub to provide support. I'd very much not add it to official documentation because that will just set unrealistic expectations.

I'm not even sure the Gitter should still be on there as none of us check in there regularly AFAIA.

@keikoro
Copy link
Collaborator

keikoro commented Apr 23, 2024

@sohang3112 But ok, the Gitter link needs at least correcting. Please update the PR so it only includes the link fix and I'll merge it.

@sohang3112
Copy link
Contributor Author

sohang3112 commented Apr 23, 2024

Adding the Reddit link is a nice thought, but I'm not aware that any of us admins – except for Zulko – ever looked at the sub to provide support. I'd very much not add it to official documentation

The Reddit link is already there in the README. If it shouldn't be mentioned, then it should be removed from README also.

@sohang3112
Copy link
Contributor Author

@keikoro Should I remove Reddit link from both README.md and CONTRIBUTING.md in my PR?

As per discussion with @keikoro at #2136, the sub-reddit is not actively monitored so it should be removed.
@sohang3112
Copy link
Contributor Author

@keikoro Removed Reddit link from both README and CONTRIBUTING. Please check & merge this PR.

@sohang3112
Copy link
Contributor Author

@keikoro Please merge this PR

@keikoro
Copy link
Collaborator

keikoro commented May 23, 2024

@sohang3112 as said before:

Please update the PR so it only includes the link fix and I'll merge it.

@sohang3112
Copy link
Contributor Author

@keikoro I have added back the Reddit link in README, so now the only diff is the Gitter link corrected in CONTRIBUTING. Please merge it now.

@coveralls
Copy link

Coverage Status

coverage: 81.904%. remained the same
when pulling 4460bb2 on sohang3112:patch-1
into bc8d1a8 on Zulko:master.

1 similar comment
@coveralls
Copy link

Coverage Status

coverage: 81.904%. remained the same
when pulling 4460bb2 on sohang3112:patch-1
into bc8d1a8 on Zulko:master.

@keikoro keikoro merged commit b275eb5 into Zulko:master May 24, 2024
6 of 21 checks passed
@keikoro
Copy link
Collaborator

keikoro commented May 24, 2024

Merged. Thanks for the fix.

Next time, please rebase/squash corrections of corrections of corrections on your end – a tiny change like this oughtn't pollute the commit history with multiple redundant commits. Thx.

@sohang3112 sohang3112 deleted the patch-1 branch May 25, 2024 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid Gitter link in CONTRIBUTING.md
3 participants