-
-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add system install powershell #1068
base: master
Are you sure you want to change the base?
add system install powershell #1068
Conversation
f52b963
to
0904ad7
Compare
cmd/system/powershell.go
Outdated
} | ||
|
||
command.Flags().StringP("version", "v", "", "The version or leave blank to determine the latest available version") | ||
command.Flags().String("path", "/usr/local/bin", "Installation path, where a powershell subfolder will be created") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, I know most of what we install goes here, but this isn't the recommended path for PowerShell
Could you consult the docs and update?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
195a852
to
c5da660
Compare
Retested the command after changes and it produced below output
|
cmd/system/powershell.go
Outdated
|
||
fmt.Printf("Installing version: %s for: %s\n", version, dlArch) | ||
|
||
semVer := strings.TrimPrefix(version, "v") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This package may cover edge cases better: https://github.com/Masterminds/semver
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Signed-off-by: Nitishkumar Singh <nitishkumarsingh71@gmail.com>
c5da660
to
9fe7a39
Compare
Description
Add powershell as system install application
Motivation and Context
design/approved
by a maintainer (required)Closes Add Powershell as system install #1067
How Has This Been Tested?
Using command
sudo ./arkade system install pwsh
produced below outputIf updating or adding a new CLI to
arkade get
, run:Types of changes
Documentation
./arkade get --format markdown
./arkade install --help
Checklist:
git commit -s