-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update src/index #1254
update src/index #1254
Conversation
Oh, I thought the first 6 should get included because the core modules require them? And the 2nd 6 are core "convenience methods" - I assume most apps would want them, but they are technically optional, someone might not want them? |
i was thinking for re-builders like webpack/browserify so for this i think it should have everything that |
@bmatusiak won't this break NodeJS since it not have localStorage? etc. |
i dont believe so.. Unless |
@amark so i moved the original index to core and copied my index to its place, modified a few things to fix require preload issues.. that was pointing to index to point to root . now the next time unbuild is ran.. it should copy to src folder |
and this fixes React-Native? I'll merge, but note I might fiddle with it again in the future if I notice anything goofy. |
for rebuilds