Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update src/index #1254

Merged
merged 5 commits into from
Dec 15, 2023
Merged

update src/index #1254

merged 5 commits into from
Dec 15, 2023

Conversation

bmatusiak
Copy link
Collaborator

for rebuilds

@bmatusiak
Copy link
Collaborator Author

@amark
Copy link
Owner

amark commented Jul 13, 2022

Oh, I thought the first 6 should get included because the core modules require them? And the 2nd 6 are core "convenience methods" - I assume most apps would want them, but they are technically optional, someone might not want them?

@bmatusiak
Copy link
Collaborator Author

i was thinking for re-builders like webpack/browserify so for this i think it should have everything that gun.js has, leaving the src folder to load same as gun.js,

@amark
Copy link
Owner

amark commented Dec 11, 2023

@bmatusiak won't this break NodeJS since it not have localStorage? etc.

@bmatusiak
Copy link
Collaborator Author

@bmatusiak won't this break NodeJS since it not have localStorage? etc.

i dont believe so.. Unless Gun becomes a global during source initialization.
but as i can see localStorage check for gun as a global and does not use 'USE/require' before it checks for gun (looks like it should). i also see people load gun/gun in node sometimes

@bmatusiak
Copy link
Collaborator Author

bmatusiak commented Dec 13, 2023

@amark so i moved the original index to core and copied my index to its place, modified a few things to fix require preload issues.. that was pointing to index to point to root .

now the next time unbuild is ran.. it should copy to src folder

@amark
Copy link
Owner

amark commented Dec 15, 2023

and this fixes React-Native?

I'll merge, but note I might fiddle with it again in the future if I notice anything goofy.

@amark amark merged commit c440a7c into amark:master Dec 15, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants