Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WS ws.path fix #1343

Merged
merged 3 commits into from
Nov 25, 2023
Merged

WS ws.path fix #1343

merged 3 commits into from
Nov 25, 2023

Conversation

bmatusiak
Copy link
Collaborator

@bmatusiak bmatusiak commented Nov 24, 2023

i found that i always run into issues with it processing the correct path.

so this should fix gun when using WebSockets with other ws protocols that attach to different paths (webpack , socket.io)

@bmatusiak
Copy link
Collaborator Author

cleaned up, ready to review @amark

@amark
Copy link
Owner

amark commented Nov 25, 2023

@bmatusiak cool, it seems like some || edge case? I don't quite understand but you seem to notice it fixes stuff & I appreciate that + trust you! You're awesome, an open source hero!!!!

@amark amark merged commit 5ff33b7 into master Nov 25, 2023
6 checks passed
@bmatusiak
Copy link
Collaborator Author

thanks! || prevents overloading it i guess. there was a edge case in the past from a comment i seen.. but i think what i did was the original intent

@bmatusiak
Copy link
Collaborator Author

i think the edge was.. if you want to host gun.js but not use the websockets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants