refactor(platform-server): minor cleanup in insertEventRecordScript logic
#55790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
action: review
alan-agius4
force-pushed
the
insertEventRecordScript-refactor
branch
4 times, most recently
from
1ad5994
to
4e98a22
Compare
… logic - Uses Set instead of a number of checks - Remove unneeded `Array.from`
alan-agius4
force-pushed
the
insertEventRecordScript-refactor
branch
from
4e98a22
to
232dc77
Compare
eneajaho
reviewed
May 14, 2024
| 'pointerenter', | ||
| 'pointerleave', | ||
| ]); | ||
| const ALLOWED_CAPTAURE_EVENT_TYPES = new Set<string>(['focus', 'blur', 'error', 'load', 'toggle']); |
There was a problem hiding this comment.
Suggested change
| const ALLOWED_CAPTAURE_EVENT_TYPES = new Set<string>(['focus', 'blur', 'error', 'load', 'toggle']); | |
| const ALLOWED_CAPTURE_EVENT_TYPES = new Set<string>(['focus', 'blur', 'error', 'load', 'toggle']); |
eneajaho
reviewed
May 14, 2024
| if (DISALLOWED_EVENT_TYPES.has(eventType)) { | ||
| continue; | ||
| } | ||
| if (ALLOWED_CAPTAURE_EVENT_TYPES.has(eventType)) { |
There was a problem hiding this comment.
Suggested change
| if (ALLOWED_CAPTAURE_EVENT_TYPES.has(eventType)) { | |
| if (ALLOWED_CAPTURE_EVENT_TYPES.has(eventType)) { |
| @@ -133,49 +133,56 @@ function appendServerContextInfo(applicationRef: ApplicationRef) { | |||
| }); | |||
| } | |||
|
|
|||
| const DISALLOWED_EVENT_TYPES = new Set<string>([ | |||
There was a problem hiding this comment.
It looks like those consts would intersect with a similar ones from PR #55799.
Comment on lines
+176
to
+177
| if (captureEventTypes.length) { | ||
| jsActionBootstrapParams.push(JSON.stringify(captureEventTypes)); |
There was a problem hiding this comment.
nit:
Suggested change
| if (captureEventTypes.length) { | |
| jsActionBootstrapParams.push(JSON.stringify(captureEventTypes)); | |
| if (captureEventTypes.length > 0) { | |
| jsActionBootstrapParams.push(JSON.stringify(captureEventTypes)); |
|
|
||
| const replayScript = createScript(doc, replayScriptContents, nonce); | ||
| // This is defined in packages/core/primitives/event-dispatch/contract_binary.ts | ||
| const jsActionBootstrapParams = [ |
AndrewKushnir
added
target: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Array.from