Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add experimental and zoneless to nav #55834

Closed
wants to merge 1 commit into from

Conversation

atscott
Copy link
Contributor

@atscott atscott commented May 16, 2024

No description provided.

@atscott atscott added target: rc This PR is targeted for the next release-candidate adev: preview labels May 16, 2024
@atscott atscott requested review from mgechev and jelbourn May 16, 2024 17:34
@angular-robot angular-robot bot added the area: docs Related to the documentation label May 16, 2024
@ngbot ngbot bot added this to the Backlog milestone May 16, 2024
Copy link

Deployed adev-preview for 296cb42 to: https://ng-dev-previews-fw--pr-angular-angular-55834-adev-prev-n9l7hy9f.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

Copy link
Member

@JeanMeche JeanMeche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -640,6 +640,12 @@ const DOCS_SUB_NAVIGATION_DATA: NavigationItem[] = [
},
],
},
{
label: 'Experimental features',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be one level higher? At the same level as "In-depth Guides". I'll also propose that we consider keeping the same name as the one on aio "Feature preview" as a category that includes both dev preview & experimental features. cc @jelbourn @mgechev

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simonaco Going one level higher would require some subcategories in that case. Do you envision something like:

/in-depth-guides
| -- Components
| -- Template Syntax

/feature-preview
|-- Dev Preview
|  |-- Zoneless
|-- Experimental

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah let's keep it as is then. And we can iterate if needed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thought, when we late move pages like this to their "correct" home, it causes confusion for developers because it moves out of the "Preview" sections, then they can't find it.

I'm good with adding an "Experimental features" section, but can we also add the page to where it goes in the in-depth guides to reduce the change later?

@twerske twerske added the action: merge The PR is ready for merge by the caretaker label May 22, 2024
@dylhunn
Copy link
Contributor

dylhunn commented May 22, 2024

This PR was merged into the repository by commit acdcec9.

@dylhunn dylhunn closed this in acdcec9 May 22, 2024
dylhunn pushed a commit that referenced this pull request May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker adev: preview area: docs Related to the documentation target: rc This PR is targeted for the next release-candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants