docs: Fix broken references to Location and LocationStrategy #55840
+4
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*Fixing broken documentation reference to LocationStrategy and Location in HashLocationStrategy oage
bougwal
changed the title
|
With #angular/dev-infra#2069 we should be able to keep the inline links. Maybe we could just make this PR an addition on the pills link ? |
|
@JeanMeche nice blazingly fast fix there for the dev-infra! We can do that for sure. You want me to wrap this PR up and and push these changes to the #55836 ? I will need another look after I push b/c i think Pawel already reviewed the other PR. Let me know what's best anyway |
|
Yes, lets wait for the merge of the dev-infra PR so we can see what we'll do after ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current:
Adding the @ see in place approach yields broken description (cc: @JeanMeche same issue as per #55836 (comment))
A small refactor as per the approach we adopted in #55836 adding the "pill" links at the end of the description