docs(zone.js): update release guide for zone.js #55846
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the releasing guide for zone.js, because one of the release commands was outdated.
dylhunn
added
area: zones
target: minor
| @@ -76,7 +78,7 @@ Releasing `zone.js` is a two step process. | |||
|
|
|||
| ``` | |||
| rm -rf node_modules && yarn install | |||
| export PREVIOUS_ZONE_TAG=`git tag -l 'zone.js-0.11.*' | tail -n1` | |||
| export PREVIOUS_ZONE_TAG=`git tag -l 'zone.js-0.14.*' | tail -n1` | |||
There was a problem hiding this comment.
I'm wondering if we should update this command to avoid having a version and use something like this instead:
Suggested change
| export PREVIOUS_ZONE_TAG=`git tag -l 'zone.js-0.14.*' | tail -n1` | |
| export PREVIOUS_ZONE_TAG=`git describe --tags --match="zone.js*" --abbrev=0 HEAD` |
We can also consider adding a couple lines to make sure that we are at the main branch and it's up to date
git fetch upstream
git checkout upstream/main
@josephperrott WDYT?
| @@ -1,6 +1,8 @@ | |||
| To run tests | |||
| ------------ | |||
|
|
|||
| *Note*: some of these tests no longer run. Be sure to check that CI is green. | |||
There was a problem hiding this comment.
I think we should move this content into the "Cutting a release" section, i.e. mention that a caretaker needs to make sure that the CI is "green" before starting the release process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the releasing guide for zone.js, because one of the release commands was outdated.