Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core): Add a bit to EventInfo to mark resolution. #55864

Closed
wants to merge 1 commit into from
Closed

refactor(core): Add a bit to EventInfo to mark resolution. #55864

wants to merge 1 commit into from

Conversation

tbondwilkinson
Copy link
Contributor

This will prevent running ActionResolver logic multiple times while migrating to use Dispatcher to resolve actions rather than EventContract.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

@tbondwilkinson
refactor(core): Add a bit to EventInfo to mark resolution.
f984c7c 
This will prevent running `ActionResolver` logic multiple times while
migrating to use `Dispatcher` to resolve actions rather than
`EventContract`.
@tbondwilkinson
Copy link
Contributor Author

TESTED=TGP

@tbondwilkinson tbondwilkinson marked this pull request as ready for review May 20, 2024 16:17
@tbondwilkinson tbondwilkinson requested review from iteriani and removed request for neonstalwart, atscott, alxhub and dylhunn May 20, 2024 16:17
@pullapprove pullapprove bot added the requires: TGP This PR requires a passing TGP before merging is allowed label May 20, 2024
@tbondwilkinson tbondwilkinson added action: review The PR is still awaiting reviews from at least one requested reviewer area: core Issues related to the framework runtime target: rc This PR is targeted for the next release-candidate core: event dispatch labels May 20, 2024
@ngbot ngbot bot added this to the Backlog milestone May 20, 2024
@pullapprove pullapprove bot requested a review from alxhub May 20, 2024 16:41
AndrewKushnir
AndrewKushnir approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

pkozlowski-opensource
pkozlowski-opensource approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@pkozlowski-opensource pkozlowski-opensource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewed-for: public-api

@tbondwilkinson tbondwilkinson removed the action: review The PR is still awaiting reviews from at least one requested reviewer label May 21, 2024
@tbondwilkinson tbondwilkinson added the action: merge The PR is ready for merge by the caretaker label May 21, 2024
@dylhunn
Copy link
Contributor

dylhunn commented May 21, 2024

This PR was merged into the repository by commit bb13174.

@dylhunn dylhunn closed this in bb13174 May 21, 2024
dylhunn pushed a commit that referenced this pull request May 21, 2024
@tbondwilkinson @dylhunn
refactor(core): Add a bit to EventInfo to mark resolution. (#55864)
b79b6c1 
This will prevent running `ActionResolver` logic multiple times while
migrating to use `Dispatcher` to resolve actions rather than
`EventContract`.

PR Close #55864
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkozlowski-opensource pkozlowski-opensource pkozlowski-opensource approved these changes

@iteriani iteriani iteriani approved these changes

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime core: event dispatch requires: TGP This PR requires a passing TGP before merging is allowed target: rc This PR is targeted for the next release-candidate
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tbondwilkinson @dylhunn @pkozlowski-opensource @iteriani @AndrewKushnir