Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using pycmarkgfm lib for rendering. #48

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Humbedooh
Copy link
Member

This would use the pycmarkgfm pip library instead of having to build and call the gfm C library. Should make things more portable.

@christ christ requested a review from gstein April 27, 2023 17:17
@sebbASF
Copy link
Contributor

sebbASF commented May 4, 2023

Why use this and not cmarkgfm? Do we need task lists?

@sebbASF
Copy link
Contributor

sebbASF commented Jun 11, 2023

Note that the installation still requires the library to be built.
However this is done as part of the pip install process which makes it much easier.

The Dockerfile will need to be reworked; by the time requirements.txt is processed, the build tools have been dropped.

@sebbASF
Copy link
Contributor

sebbASF commented Jun 11, 2023

There are various references to LIBCMARKDIR in the code which need to be fixed before this can be deployed

@sebbASF
Copy link
Contributor

sebbASF commented Jun 11, 2023

AFAICT there are minimal differences in the generated output, at least for the main website.

There are some minor spacing and line-wrap differences between tags.

The only other difference I noticed is that URLs such as:

http://people.apache.org/%7Ecurcuru
are now rendered as
http://people.apache.org/~curcuru

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants