New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hex decode add-prefix and remove-prefix for fdbrestore. #11344
Merged
jzhou77
merged 4 commits into
apple:release-7.3
from
customerio:issue_1537_release_7_3_fix
Apr 30, 2024
Merged
Hex decode add-prefix and remove-prefix for fdbrestore. #11344
jzhou77
merged 4 commits into
apple:release-7.3
from
customerio:issue_1537_release_7_3_fix
Apr 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzhou77
previously approved these changes
Apr 29, 2024
jzhou77
reviewed
Apr 29, 2024
fdbbackup/backup.actor.cpp
Outdated
// into the binary string. Set "err" to true if the format is invalid. | ||
// Note ',' '\' '," ';' are escaped by '\'. Normal characters can be | ||
// unencoded into HEX, but not recommended. | ||
std::string decode_hex_string(std::string line, bool& err) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe refactor this into a separate file to be shared with FileDecoder.actor.cpp
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did that. Added Decode.cpp.
Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x
|
Result of foundationdb-pr-macos on macOS Ventura 13.x
|
Result of foundationdb-pr-clang on Linux CentOS 7
|
Result of foundationdb-pr-cluster-tests on Linux CentOS 7
|
Result of foundationdb-pr on Linux CentOS 7
|
jzhou77
approved these changes
Apr 30, 2024
kakaiu
approved these changes
Apr 30, 2024
Result of foundationdb-pr-cluster-tests on Linux CentOS 7
|
Result of foundationdb-pr-clang on Linux CentOS 7
|
Result of foundationdb-pr on Linux CentOS 7
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is fix for #1537.
--add-prefix
and--remove-prefix
command line arguments to fdbrestore are not hex decoded.This also fixes a bug in the original
decode_hex_string
implementation where an error condition is not correctly flagged.I tested the implementation locally and it works as expected.
Once this PR is merged I can create a fix against main.
Code-Reviewer Section
The general pull request guidelines can be found here.
Please check each of the following things and check all boxes before accepting a PR.
For Release-Branches
If this PR is made against a release-branch, please also check the following:
release-branch
ormain
if this is the youngest branch)