New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[lldb] Factor out function for experimental properties (NFC) #8298
base: stable/20230725
Are you sure you want to change the base?
[lldb] Factor out function for experimental properties (NFC) #8298
Conversation
@swift-ci test |
@swift-ci test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice clean up!
@@ -310,6 +310,10 @@ class TargetProperties : public Properties { | |||
bool GetEnableTrampolineSupport() const; | |||
|
|||
private: | |||
std::optional<bool> | |||
GetExperimentalPropertyValue(size_t idx, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this function live upstream?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep. (on first glance I thought these were all swift, but one property, inject-local-vars
, does exist upstream).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll pick llvm#83504 into this branch.
@swift-ci test Windows |
Factor out a reusable function for
target.experimental
properties.