Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lldb] Add lldb-dap to Linux distribution #8565

Closed

Conversation

adam-fowler
Copy link

In #8176 lldb-dap was added to the macOS distribution

This PR does the same but for Linux

@adrian-prantl
Copy link
Member

Can you rebase this to the swift/release/6.0 branch?
Is this Swift-specific? If not this commit should be made on the llvm.org branch and then cherry-picked.

@adam-fowler
Copy link
Author

adam-fowler commented Apr 12, 2024

Can you rebase this to the swift/release/6.0 branch? Is this Swift-specific? If not this commit should be made on the llvm.org branch and then cherry-picked.

I was just copying the PR from @JDevlieghere but you are right these are files that are in the original llvm repo. I shall make the change there first. Although these changes are specific to Swift in that they define what goes into the Swift distribution.

By rebase to swift/release/6.0 branch do you want me to redirect the PR to merge into this branch?

@adam-fowler
Copy link
Author

adam-fowler commented Apr 12, 2024

Here is the PR to upstream llvm repository llvm#88482, but re-reading your comment do you want me to apply this to llvm.org branch in this repo?

@adam-fowler
Copy link
Author

Closed in favour of #8573

@adam-fowler adam-fowler deleted the linux-lldb-dap branch April 13, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants