Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for null oso SymbolFile in SymbolFileDwarfDebugMap::ResolveSymb… #8607

Open
wants to merge 1 commit into
base: swift/release/6.0
Choose a base branch
from

Commits on Apr 19, 2024

  1. Check for null oso SymbolFile in SymbolFileDwarfDebugMap::ResolveSymb…

    …olContext (llvm#89324)
    
    The couple other places that use the oso module's SymbolFile, they check
    that it's non-null, so this is just an oversight in
    ResolveSymbolContext.
    
    I didn't add a test for this (but did add a log message for the error
    case) because I can't see how this would actually happen. The .o file
    had to have valid enough DWARF that the linker's parser could handle it
    or it would not be in the debug map. If you delete the .o file, we just
    leave that entry out of the debug map. If you strip it or otherwise mess
    with it, we'll notice the changed mod time and refuse to read it...
    
    This was based on a report from the field, and we don't have access to
    the project. But if the logging tells me how this happened I can come
    back and add a test with that example.
    
    (cherry picked from commit 6b38936)
    jimingham committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    7e04008 View commit details
    Browse the repository at this point in the history