Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename note to notification throughout the codebase #865

Open
ahoppen opened this issue Oct 9, 2023 · 1 comment · May be fixed by #893
Open

Rename note to notification throughout the codebase #865

ahoppen opened this issue Oct 9, 2023 · 1 comment · May be fixed by #893
Labels
good first issue Good for newcomers refactoring An internal refactoring of the codebase

Comments

@ahoppen
Copy link
Collaborator

ahoppen commented Oct 9, 2023

We use the term note in a bunch of places where we mean a notification. This is confusing because note is very much not a standard abbreviation of notification and we do use notes in the context of IDEs as diagnostics.

We should rename all those occurrences to notification to avoid confusion.
@ahoppen ahoppen added good first issue Good for newcomers refactoring An internal refactoring of the codebase labels Oct 9, 2023
@ahoppen
Copy link
Collaborator Author

ahoppen commented Oct 9, 2023

Tracked in Apple’s issue tracker as rdar://116703667

issamarabi added a commit to issamarabi/sourcekit-lsp that referenced this issue Oct 11, 2023
@issamarabi
Rename note to notification throughout the codebase apple#865
ac36205
issamarabi added a commit to issamarabi/sourcekit-lsp that referenced this issue Oct 11, 2023
@issamarabi
Rename note to notification throughout the codebase apple#865
c34c279
@issamarabi issamarabi linked a pull request Oct 11, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers refactoring An internal refactoring of the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename note to notification throughout the codebase issamarabi/sourcekit-lsp
1 participant
@ahoppen