New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename note to notification throughout the codebase #893
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @issamarabi. I have a few comments inline but otherwise it looks good to me.
/// If this is from a note, the note's description should be passed as `fromNote`. | ||
init?(fixits: SKDResponseArray, in snapshot: DocumentSnapshot, fromNote: String?) { | ||
/// If this is from a notification, the notification's description should be passed as `fromNotification`. | ||
init?(fixits: SKDResponseArray, in snapshot: DocumentSnapshot, fromNotification: String?) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is about diagnostics, which do indeed have notes, not notifications. Could you change it back?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed these back. Let me know if this works!
if let diag = CachedDiagnostic(diag, in: snapshot, useEducationalNoteAsCode: supportsCodeDescription) { | ||
if let diag = CachedDiagnostic(diag, in: snapshot, useEducationalNotificationAsCode: supportsCodeDescription) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is about notes, not notifications, so useEducationalNoteAsCode
is correct.
@@ -760,11 +760,11 @@ final class LocalSwiftTests: XCTestCase { | |||
) | |||
} | |||
} else { | |||
XCTFail("missing '?' note") | |||
XCTFail("missing '?' notification") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is talking about diagnostics and should be note
.
XCTFail("missing '!' note") | ||
XCTFail("missing '!' notification") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, talking about diagnostics.
Co-authored-by: Alex Hoppen <alex@alexhoppen.de>
Co-authored-by: Alex Hoppen <alex@alexhoppen.de>
Co-authored-by: Alex Hoppen <alex@alexhoppen.de>
Co-authored-by: Alex Hoppen <alex@alexhoppen.de>
Argh, looks like this conflicted quite heavily with #896. Could you rebase the PR on top of Sorry for causing the conflicts. |
Fixes #865
note
withnotification
.Originated from feedback by @ahoppen regarding terminology confusion. This change aims to maintain clarity across the codebase.
Reference: Apple’s issue tracker rdar://116703667
Please review.