Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add separate "add test" manifest actions for XCTest and Swift Testing #1197

Conversation

DougGregor
Copy link
Member

@DougGregor
Copy link
Member Author

apple/swift-package-manager#7481

@swift-ci please test

1 similar comment
@DougGregor
Copy link
Member Author

apple/swift-package-manager#7481

@swift-ci please test


actions.append(
CodeAction(
title: "Add test target (\(libraryName))",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A single test target can contain code for both XCTest and swift-testing. (See my comments over on apple/swift-package-manager#7481.)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As noted over in apple/swift-package-manager#7481, a code action that creates a brand-new test target that uses two different test libraries is not useful.

@DougGregor DougGregor force-pushed the package-editing-refactor-with-swift-testing branch from cf6a78c to bbe3e2b Compare April 23, 2024 16:47
@DougGregor
Copy link
Member Author

apple/swift-package-manager#7481

@swift-ci please test

@DougGregor
Copy link
Member Author

apple/swift-package-manager#7481

@swift-ci please test Windows

1 similar comment
@DougGregor
Copy link
Member Author

apple/swift-package-manager#7481

@swift-ci please test Windows

@DougGregor
Copy link
Member Author

apple/swift-package-manager#7481

@swift-ci please test macOS

@DougGregor DougGregor force-pushed the package-editing-refactor-with-swift-testing branch from bbe3e2b to 8293e06 Compare April 24, 2024 16:42
@DougGregor
Copy link
Member Author

apple/swift-package-manager#7481

@swift-ci please test Windows

7 similar comments
@DougGregor
Copy link
Member Author

apple/swift-package-manager#7481

@swift-ci please test Windows

@DougGregor
Copy link
Member Author

apple/swift-package-manager#7481

@swift-ci please test Windows

@DougGregor
Copy link
Member Author

apple/swift-package-manager#7481

@swift-ci please test Windows

@DougGregor
Copy link
Member Author

apple/swift-package-manager#7481

@swift-ci please test Windows

@DougGregor
Copy link
Member Author

apple/swift-package-manager#7481

@swift-ci please test Windows

@DougGregor
Copy link
Member Author

apple/swift-package-manager#7481

@swift-ci please test Windows

@DougGregor
Copy link
Member Author

apple/swift-package-manager#7481

@swift-ci please test Windows

@DougGregor
Copy link
Member Author

apple/swift-package-manager#7481

@swift-ci please test Windows

@DougGregor
Copy link
Member Author

apple/swift-package-manager#7509

@swift-ci clean test Windows

@DougGregor DougGregor force-pushed the package-editing-refactor-with-swift-testing branch from 84163ce to 81699f0 Compare May 8, 2024 05:51
@DougGregor
Copy link
Member Author

apple/swift-package-manager#7481

@swift-ci please test

@DougGregor
Copy link
Member Author

apple/swift-package-manager#7481

@swift-ci please test Windows

@DougGregor DougGregor force-pushed the package-editing-refactor-with-swift-testing branch from 81699f0 to 638fd5b Compare May 8, 2024 05:52
@DougGregor
Copy link
Member Author

apple/swift-package-manager#7481

@swift-ci please test

@DougGregor
Copy link
Member Author

apple/swift-package-manager#7481

@swift-ci please test Windows

1 similar comment
@DougGregor
Copy link
Member Author

apple/swift-package-manager#7481

@swift-ci please test Windows

@DougGregor
Copy link
Member Author

apple/swift-package-manager#7481

@swift-ci please clean test Windows

@DougGregor
Copy link
Member Author

apple/swift-package-manager#7481

@swift-ci clean test Windows

@DougGregor
Copy link
Member Author

@DougGregor DougGregor merged commit f0d869f into apple:main May 8, 2024
3 checks passed
@DougGregor DougGregor deleted the package-editing-refactor-with-swift-testing branch May 8, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants