New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add separate "add test" manifest actions for XCTest and Swift Testing #1197
Add separate "add test" manifest actions for XCTest and Swift Testing #1197
Conversation
apple/swift-package-manager#7481 @swift-ci please test |
1 similar comment
apple/swift-package-manager#7481 @swift-ci please test |
|
||
actions.append( | ||
CodeAction( | ||
title: "Add test target (\(libraryName))", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A single test target can contain code for both XCTest and swift-testing. (See my comments over on apple/swift-package-manager#7481.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As noted over in apple/swift-package-manager#7481, a code action that creates a brand-new test target that uses two different test libraries is not useful.
cf6a78c
to
bbe3e2b
Compare
apple/swift-package-manager#7481 @swift-ci please test |
apple/swift-package-manager#7481 @swift-ci please test Windows |
1 similar comment
apple/swift-package-manager#7481 @swift-ci please test Windows |
apple/swift-package-manager#7481 @swift-ci please test macOS |
bbe3e2b
to
8293e06
Compare
apple/swift-package-manager#7481 @swift-ci please test Windows |
7 similar comments
apple/swift-package-manager#7481 @swift-ci please test Windows |
apple/swift-package-manager#7481 @swift-ci please test Windows |
apple/swift-package-manager#7481 @swift-ci please test Windows |
apple/swift-package-manager#7481 @swift-ci please test Windows |
apple/swift-package-manager#7481 @swift-ci please test Windows |
apple/swift-package-manager#7481 @swift-ci please test Windows |
apple/swift-package-manager#7481 @swift-ci please test Windows |
apple/swift-package-manager#7481 @swift-ci please test Windows |
apple/swift-package-manager#7509 @swift-ci clean test Windows |
84163ce
to
81699f0
Compare
apple/swift-package-manager#7481 @swift-ci please test |
apple/swift-package-manager#7481 @swift-ci please test Windows |
81699f0
to
638fd5b
Compare
apple/swift-package-manager#7481 @swift-ci please test |
apple/swift-package-manager#7481 @swift-ci please test Windows |
1 similar comment
apple/swift-package-manager#7481 @swift-ci please test Windows |
apple/swift-package-manager#7481 @swift-ci please clean test Windows |
apple/swift-package-manager#7481 @swift-ci clean test Windows |
apple/swift#73507 @swift-ci please test Linux |
Builds on #1193 and apple/swift-package-manager#7481