Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BuildServerBuildSystem: share more code across platforms #658

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

BuildServerBuildSystem: share more code across platforms #658

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 5 additions & 5 deletions Sources/SKCore/BuildServerBuildSystem.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,14 +71,14 @@ public final class BuildServerBuildSystem {
let configPath = projectRoot.appending(component: "buildServer.json")
let config = try loadBuildServerConfig(path: configPath, fileSystem: fileSystem)
#if os(Windows)
self.searchPaths =
getEnvSearchPaths(pathString: ProcessInfo.processInfo.environment["Path"],
currentWorkingDirectory: fileSystem.currentWorkingDirectory)
let pathEnvironmentVar = "Path"
#else
let pathEnvironmentVar = "PATH"
#endif
self.searchPaths =
getEnvSearchPaths(pathString: ProcessInfo.processInfo.environment["PATH"],
getEnvSearchPaths(pathString: ProcessInfo.processInfo.environment["Path"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to use pathEnvironmentVar here?

currentWorkingDirectory: fileSystem.currentWorkingDirectory)
#endif

self.buildFolder = buildFolder
self.projectRoot = projectRoot
self.requestQueue = DispatchQueue(label: "build_server_request_queue")
Expand Down