Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SwiftPM: Treating Package.resolved as a lock file #2212

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

FranzBusch
Copy link
Contributor

No description provided.

@FranzBusch FranzBusch force-pushed the fb-swiftpm-package-resolved-lock-file branch from efcbef3 to a0d2a56 Compare November 15, 2023 10:58
would allow library authors to test if their packages work with their lowest
declared dependency versions.

### `--percise` and `--agressive` options for swift package update
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### `--percise` and `--agressive` options for swift package update
### `--precise` and `--agressive` options for swift package update

@FranzBusch FranzBusch force-pushed the fb-swiftpm-package-resolved-lock-file branch from a0d2a56 to a3bcf6a Compare November 15, 2023 11:10
Co-authored-by: Max Desiatov <m_desiatov@apple.com>
@rjmccall rjmccall added the swiftpm Proposal relates to the Swift Package Manager label Dec 14, 2023
@rjmccall rjmccall added the PSG Contains topics under the domain of the Platform Steering Group label Apr 1, 2024

#### Description

If a `Package.resolved` file is present, this command will fetch all dependencies
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Restating swift package fetch instead of this command would make this sentence easier to read.


If a `Package.resolved` file is present, this command will fetch all dependencies
and make them locally available. Making them locally available means cloning the
git repositories or downloading the artefact. Subsequent commands will be able
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: did you mean artifacts?

`Package.swift` this command will prompt the user to ask to update if run from an
interactive terminal otherwise it will fail with an error.

> Note: Determining if the `Package.resolved` is out of data is done by storing a
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: out of date*


> Note: Determining if the `Package.resolved` is out of data is done by storing a
hash of the `Package.swift` in the `Package.resolved` and comparing it when
executing the fetch command. Implemented in swift-package-manager/pull/6698
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: reference to a pull request is not a link in this form


#### Description

If a `Package.resolved` is present, this command will try to update it to the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same not about this command as above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PSG Contains topics under the domain of the Platform Steering Group swiftpm Proposal relates to the Swift Package Manager
Projects
None yet
4 participants