Add upcoming feature flag to SE-0337 to match inclusion in compiler #2384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add 'Implemented in 6.0' to match guidance the flag should not be used as an upcoming feature flag until Swift 6.0 - Annotate that flag is always enabled in Swift 6 language mode
rjmccall
added
LSG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An upcoming feature flag is included for SE-0337 in the definition of upcoming features in the compiler.
According to the recent documentation on swift.org about enabling strict concurrency by @hborla, the flag
StrictConcurrencyshould only be used as an upcoming feature flag beginning with Swift 6.0 tools. (With it used as an experimental feature flag in 5.9 and 5.10).From @DougGregor's comment in apple/swift#66992:
This PR adds the upcoming feature flag for this proposal that should be used with Swift 6.0 tools.
It annotates the flag with "Implemented in 6.0" to indicate when the flag should begin being used, similar to how other flags are annotated.
It also has the new "Enabled in Swift 6 language mode" to indicate that strict concurrency is always enabled in Swift 6 language mode.
// cc-ing authors and review manager to ensure this change is correct
@DougGregor @beccadax @airspeedswift