Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize review metadata #2417

Merged

Conversation

dempseyatgithub
Copy link
Contributor

This PR normalizes Review field metadata for proposals with bare discussion links and addresses any other metadata issues present.

  • Make bare discussion links into explicit links
  • Add missing pitch, review, and acceptance links as applicable
  • Change field name and order to match proposal template
  • Add explicit implementation links to SE-0391

- Make bare discussion links into explicit links
- Add missing pitch, review, and acceptance links as applicable
- Change field order to match proposal template
- Add explicit implementation links to SE-0391
Copy link
Member

@rjmccall rjmccall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rjmccall rjmccall merged commit 7f20335 into apple:main Apr 29, 2024
@dempseyatgithub dempseyatgithub deleted the normalize-malformed-review-metadata branch May 1, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants