Vend modulesPath as API to SourceKit-LSP
#7200
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
apple/sourcekit-lsp#998 |
MaxDesiatov
reviewed
Dec 14, 2023
| @@ -526,7 +526,7 @@ public class BuildPlan: SPMBuildCore.BuildPlan { | |||
| for target in targets { | |||
| switch target { | |||
| case .swift(let targetDescription): | |||
| arguments += ["-I", targetDescription.moduleOutputPath.parentDirectory.pathString] | |||
| arguments += ["-I", targetDescription.modulesPath.pathString] | |||
There was a problem hiding this comment.
These paths aren't the same I assume? If so, shouldn't this change have some impact on the test suite, either requiring to update tests or add a new one?
There was a problem hiding this comment.
They're the same in the majority of cases
There was a problem hiding this comment.
Right, I'm worried about the fact that the remaining minority of cases doesn't seem to be covered with tests, otherwise this change would've broken such tests?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.