Add BreadBuddy to projects.json #662
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BreadBuddy is an open-source reference app for using MVVM with SwiftUI.
shahmishal
reviewed
Jun 1, 2022
projects.json
Outdated
| "branch": "master", | ||
| "maintainer": "max@bracket.ltd", | ||
| "compatibility": { | ||
| "5.6.1": { |
There was a problem hiding this comment.
Can we update this to 5.0? we are trying to keep the compatibility to supported swift versions.
- Swift 4.0
- Swift 4.2
- Swift 5.0
There was a problem hiding this comment.
Yeah, shouldn’t be a problem. Would you like me to adjust? Or leave it to you?
|
@swift-ci test |
Change version to 5.0
|
Just bumped it down to 5.0. Let me know if you need anything else! |
|
@swift-ci test |
🤪 |
|
Hi @maxhumber 👋 , looks like the build system had an issue finding the xcodeproj file specified in this PR |
shahmishal
reviewed
Aug 5, 2022
Co-authored-by: Mishal Shah <shahmishal@users.noreply.github.com>
|
Changes committed! |
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
BreadBuddy is an open-source reference app for using MVVM with SwiftUI.
Acceptance Criteria
To be accepted into the Swift source compatibility test suite, a project must:
./project_precommit_checkscript runEnsure project meets all listed requirements before submitting a pull request.