Add arena to syntax nodes

apple · Aug 17, 2023 · d2d2ae3 · d2d2ae3
1 parent 1060677
commit d2d2ae3
Show file tree

Hide file tree

Showing 10 changed files with 1,135 additions and 679 deletions.
diff --git a/CodeGeneration/Sources/generate-swiftsyntax/LayoutNode+Extensions.swift b/CodeGeneration/Sources/generate-swiftsyntax/LayoutNode+Extensions.swift
@@ -66,6 +66,9 @@ extension LayoutNode {
 
       FunctionParameterSyntax("trailingTrivia: Trivia? = nil")
         .with(\.leadingTrivia, .newline)
+
+      FunctionParameterSyntax("arena: __shared SyntaxArena = SyntaxArena()")
+        .with(\.leadingTrivia, .newline)
     }
 
     return """

diff --git a/...Sources/generate-swiftsyntax/templates/swiftsyntax/RenamedChildrenCompatibilityFile.swift b/...Sources/generate-swiftsyntax/templates/swiftsyntax/RenamedChildrenCompatibilityFile.swift
@@ -93,6 +93,7 @@ let renamedChildrenCompatibilityFile = try! SourceFileSyntax(leadingTrivia: copy
             }
           }
           LabeledExprSyntax(label: "trailingTrivia", expression: ExprSyntax("trailingTrivia"))
+          LabeledExprSyntax(label: "arena", expression: ExprSyntax("arena"))
         }
       }
     }

diff --git a/CodeGeneration/Sources/generate-swiftsyntax/templates/swiftsyntax/SyntaxNodesFile.swift b/CodeGeneration/Sources/generate-swiftsyntax/templates/swiftsyntax/SyntaxNodesFile.swift
@@ -116,7 +116,7 @@ func syntaxNode(emitKind: SyntaxNodeKind) -> SourceFileSyntax {
             calledExpression: ExprSyntax("withExtendedLifetime"),
             leftParen: .leftParenToken(),
             arguments: LabeledExprListSyntax {
-              LabeledExprSyntax(expression: ExprSyntax("(SyntaxArena(), (\(parameters)))"))
+              LabeledExprSyntax(expression: ExprSyntax("(arena, (\(parameters)))"))
             },
             rightParen: .rightParenToken(),
             trailingClosure: ClosureExprSyntax(signature: closureSignature) {