Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't declare attribute names as keywords #2486

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Don't declare attribute names as keywords #2486

wants to merge 3 commits into from

Commits on Feb 7, 2024

  1. Don't declare attribute names as keywords 

    They were declared as `Keyword` only for `TokenSpecs`
(DeclarationAttributeWithSpecialSyntax and TypeAttribute), the attribute
names are always parsed as `TypeSyntax` so those keywords weren't even
appear in the parsed syntax tree.

Instead, make those `TokenSpecSet` to accept `.identifier` lexemes.
    @rintaro
    rintaro committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    20528bf View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2024

  1. Add relesase notes for attribute name keyword removal

    @rintaro
    rintaro committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    b0b5e46 View commit details
    Browse the repository at this point in the history

  2. [Parser] Introduce TokenSpec for fixed text 

    Matches a specific tokenText. Use it in decl/type attribute
TokenSpecSet.
    @rintaro
    rintaro committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    dbcc021 View commit details
    Browse the repository at this point in the history