Update lifetime dependence syntax #2564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
Please test with following pull request: @swift-ci Please test |
1 similar comment
|
Please test with following pull request: @swift-ci Please test |
meg-gupta
force-pushed
the
updatelifetimesyntax
branch
from
6419bb5
to
a22fb3d
Compare
|
Please test with following pull request: @swift-ci Please test |
|
@swift-ci smoke test windows platform |
ahoppen
reviewed
Mar 25, 2024
| SPECIFIER_PARSING: while canHaveParameterSpecifier { | ||
| if let (_, specifierHandle) = self.at(anyIn: SimpleTypeSpecifierSyntax.SpecifierOptions.self) { | ||
| specifiers.append(parseSimpleTypeSpecifier(specifierHandle: specifierHandle)) | ||
| } else if self.at(TokenSpec(.dependsOn)) { |
There was a problem hiding this comment.
Can be simplified slightly to
} else if self.at(.keyword(.dependsOn)) {
meg-gupta
added a commit
that referenced
this pull request
Mar 27, 2024
Update lifetime dependence syntax
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pitch - apple/swift-evolution#2305
Update spellings to:
dependsOn(paramName...) and dependsOn(scoped paramName...) syntax