Make Configuration.TestFilter a pure-data type #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stmontgomery
added
enhancement
stmontgomery
requested review from
grynspan,
dennisweissmann,
briancroom,
SeanROlszewski and
suzannaratcliff
as code owners
|
@swift-ci please test |
grynspan
reviewed
Apr 17, 2024
grynspan
reviewed
Apr 17, 2024
grynspan
reviewed
Apr 17, 2024
grynspan
reviewed
Apr 17, 2024
grynspan
reviewed
Apr 17, 2024
dennisweissmann
approved these changes
Apr 17, 2024
grynspan
reviewed
Apr 17, 2024
| func apply(to testGraph: Graph<String, Test?>) -> Graph<String, Test?> { | ||
| var result = _kind.apply(to: testGraph) | ||
| func apply(to testGraph: Graph<String, Test?>) throws -> Graph<String, Test?> { | ||
| var result = try Operation(_predicate).apply(to: testGraph) |
There was a problem hiding this comment.
Do we ever need to separate Operation from apply(to:)? If not, can we just absorb the former into apply(to:)?
There was a problem hiding this comment.
You mean e.g. inline Operation enum into this function? I considered that but felt it would make the function body quite a bit more complicated. As it stands we're using access control to scope it pretty narrowly
There was a problem hiding this comment.
We could still split up the implementation into multiple functions/steps, but keep the interface simple.
grynspan
reviewed
Apr 17, 2024
grynspan
reviewed
Apr 17, 2024
|
@swift-ci please test |
Resolves rdar://126627664
stmontgomery
force-pushed
the
codable-configuration
branch
from
92e8a0a
to
35624d5
Compare
|
@swift-ci please test |
|
@swift-ci please test |
stmontgomery
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the structure of
Configuration.TestFilterso that it's a pure data type and is easier to become serializable.Motivation:
For easier integration with tools it would be helpful for the stored properties of
Configurationto be serializable, or be trivially convertible to/from serializable types at least.Configuration's nestedTestFiltertype currently includes a closure for filtering tests and is therefore cannot be serialized in its current form. This type doesn't really need to store a closure, however; it only needs to store information about how to perform filtering (e.g. data about criteria to match against), and later that can be interpreted when applying filtering.Modifications:
Configuration.TestFilter.Kindenum so that its cases only store data, and no closures.Kindtype above to a newConfiguration.TestFilter.Operationenum.Checklist:
Resolves rdar://126627664