[Macros] Use 'LibraryPluginProvider' in swift-plugin-server #69236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
apple/swift-syntax#2300 |
3 similar comments
|
apple/swift-syntax#2300 |
|
apple/swift-syntax#2300 |
|
apple/swift-syntax#2300 |
rintaro
force-pushed
the
macros-library-provider
branch
4 times, most recently
from
120f6aa
to
4dc6307
Compare
|
apple/swift-syntax#2300 |
rintaro
force-pushed
the
macros-library-provider
branch
from
4dc6307
to
7e76ead
Compare
|
@swift-ci Please smoke test |
|
apple/swift-syntax#2300 |
rintaro
force-pushed
the
macros-library-provider
branch
from
7e76ead
to
dd1b608
Compare
|
apple/swift-syntax#2300 |
|
apple/swift-syntax#2300 |
1 similar comment
|
apple/swift-syntax#2300 |
rintaro
force-pushed
the
macros-library-provider
branch
from
dd1b608
to
59c9c9a
Compare
Move 'PluginProvider' logic to 'SwiftLibraryPluginProvider' module so the compiler can reuse that logic for the actual in-process plugins.
rintaro
force-pushed
the
macros-library-provider
branch
from
59c9c9a
to
26dbe2f
Compare
|
apple/swift-syntax#2300 |
hamishknight
approved these changes
May 2, 2024
ahoppen
approved these changes
May 3, 2024
|
apple/swift-syntax#2300 |
This was referenced May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move
PluginProviderlogic toSwiftCompilerPluginMessageHandlingmodule so the compiler can reuse that logic for the in-process plugins (in follow-ups)Remove
CPluginServeras nothing uses it anymore