Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reference for Copyable #73238

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

amartini51
Copy link
Contributor

Fixes: rdar://126377559

@amartini51 amartini51 requested a review from kavon April 25, 2024 00:00
@amartini51 amartini51 requested a review from a team as a code owner April 25, 2024 00:00
@amartini51
Copy link
Contributor Author

amartini51 commented Apr 25, 2024

Unlike the reference for Sendable I didn't add a cross reference to "The Swift Programming Language" at the end of the overview. I'm not sure if there will just one place in TSPL that discusses noncopyable types, or if the content will end up needing to be spread across multiple chapters. If we do find a good place to link, we can come back and add one later on.

Incorporates feedback from Slava Pestov <spestov@apple.com>
@amartini51
Copy link
Contributor Author

@swift-ci Please smoke test

@amartini51
Copy link
Contributor Author

@swift-ci Please smoke test

Copy link
Contributor

@kavon kavon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I think this is good! Only one minor suggestion.

/// * Actor declarations
/// * Protocol declarations
/// * Associated type declarations
/// * The `Self` type in a protocol extension
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we consider whether to call out the generic parameters in an extension of a generic type? Something like:

Suggested change
/// * The `Self` type in a protocol extension
/// * The `Self` type in a protocol extension
/// * The generic parameters of a nominal type in an extension

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/nominal type/extended type/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants