[6.0] Document Debug Info & Fix discovered bugs #73324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Snowy1803
commented
Apr 29, 2024
•
Snowy1803
commented
- Explanation: This PR adds the document about how to update debug info, and fixes bugs related to debug values: undef values are no longer removed, arithmetic works, and constant literals work. It also adds support for salvaging integer literals.
- Scope: Adds debug values in swift passes, and pass undef values correctly to LLVM.
- Original PR: [DebugInfo] Improve documentation & Fix discovered bugs #73276 + Add the beginning of a Debug Info guide for SIL pass authors. #73122 + Fix salvage integer literal test on 32 bits #73330
- Risk: Low, only changes to debug values
- Testing: New tests have been added, existing ones have been updated
- Issue: None
- Reviewer: @adrian-prantl
This document describes how debug info works at the SIL level and how to correctly update debug info in SIL optimization passes. This document is inspired by its LLVM analog, "How to Update Debug Info: A Guide for LLVM Pass Authors", which can be found at https://llvm.org/docs/HowToUpdateDebugInfo.html (cherry picked from commit 22afb55)
(cherry picked from commit 9c9f14f)
(cherry picked from commit c2c16f5)
(cherry picked from commit 8ad3066)
(cherry picked from commit 84dae7c)
(cherry picked from commit 16c57ae)
|
@swift-ci please test |
rdar://127255781 (cherry picked from commit 26cb139)
|
@swift-ci please test |
adrian-prantl
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.