[SILGen] Fix a bug where the wrong convention was being used for computing the type of a closure thunk #73336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
Explanation: Swift compiler incorrectly rejects a program in which a swift closure is passed to a C++ function that takes a pointer to a function taking a non-trivial C++ type (see the code in the regression test). This is caused by a bug where the ObjC selector family convention is used instead of the C function pointer convention to get the SIL function type. |
DougGregor
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ObjC selector family convention was being used instead of the C function type convention.
rdar://127090209
(cherry picked from commit 428fe21)