-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No logs accessible in the UI on workflows that went from Pending to Running #10178
Comments
@fdebuire it is expected behavior. Even workflow is in a running state |
I meant even after all the workflows are completed, logs are still not accessible from the UI for pods of workflows that went through the phase Unknown -> Pending -> Running, it's fine for workflows which went Unknown -> Running. |
@fdebuire are you able to access the pod's logs using |
@sarabala1979 yes the pod's logs are accessible using the |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
So the default case of this should have been fixed by #11016. It will be broken if you're using
This analysis makes sense to me and seems accurate; the other location seems to have been indeed missed per #6982 (comment). I also updated the code links to use permalinks to a commit hash from the time of the initial comment. The lock transition logic originates from #6356 which has a very good reason. I'm a little hesitant to completely change it though as this part of the code is latency sensitive -- it shouldn't be doing much if the Workflow doesn't have a lock 😕 |
I wrote up a fix for the annotation in #12965 as that's the simpler case.
I don't quite have an optimal solution for this yet so I filed an issue to document it at least in #12966. |
Pre-requisites
:latest
What happened/what you expected to happen?
Argo Workflows controller is configured with
parallelism: 10
.Workflows that are created in pending, because too many workflows are already running, will not have the annotation
workflows.argoproj.io/pod-name-format: v2
associated to them, therefore logs will not be able to be viewed using the UI.It can be reproduced using the attached workflow and the command:
It seems to happen because the annotation is only set here:
argo-workflows/workflow/controller/operator.go
Line 271 in 2eb871b
but not here:
argo-workflows/workflow/controller/operator.go
Line 251 in 2eb871b
Version
latest
Paste a small workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.
Logs from the workflow controller
Logs from in your workflow's wait container
The text was updated successfully, but these errors were encountered: