fix(controller): set pod name version annotation when no lock #12965
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10178, Fixes #6982 (comment), Fixes #10735 (comment)
Partly addresses #6356 (comment), but not entirely, as the PDB is a more complicated case. Will file a separate issue for that. EDIT: filed #12966
Motivation
setWfPodNamesAnnotation
was added to theUnknown
phase check a few lines below this, but not to this lineUnknown
is handledModifications
add
setWfPodNamesAnnotation
to the otherUnknown
phase block&&
rather than nestingslightly simplify
setWfPodNamesAnnotation
as wellVerification
Tested with the same Workflow from #12966, creating two in quick succession (one waits on the mutex lock from the other),
workflows.argoproj.io/pod-name-format: v2
annotations present in both.Should probably add a case to
operator_concurrency_test.go
, TBD