-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: consistently set executor log options #12979
Open
agilgur5
wants to merge
8
commits into
argoproj:main
Choose a base branch
from
agilgur5:fix-exec-log-opts
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- for all commands, including `emissary`, `agent`, `resource`, and `data` - set loglevel, gloglevel, and log format - replace `getExecutorLogLevel` helper with `getExecutorLogOpts` helper - also add a helper in `/util/cmd` to get the gloglevel Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
agilgur5
commented
Apr 24, 2024
Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
tczhao
reviewed
May 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we also comment in the CLIs
that gloglevel
is k8s go-client logging level range 0-10
You mean making this line more specific? I didn't change the option in this PR, just made it actually used, but could improve that for sure |
Merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/agent
Argo Agent that runs for HTTP and Plugin templates
area/controller
Controller issues, panics
area/executor
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12788, Fixes #12929 (comment)
Motivation
Modifications
for all commands, including
emissary
,agent
,resource
, anddata
replace
getExecutorLogLevel
helper withgetExecutorLogOpts
helperadd a helper in
util/cmd/glog.go
to get the gloglevelVerification
Existing tests pass