fix: prevent pod from being deleted before workflow taskresult complete. Fixes: #12993 #13051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. Fixes:argoproj#12993 Signed-off-by: shuangkun <tsk2013uestc@163.com>
shuangkun
force-pushed
the
setTaskResultCompleted
branch
from
e0bba7a
to
0f9dd8a
Compare
shuangkun
force-pushed
the
setTaskResultCompleted
branch
from
0f9dd8a
to
c4b758c
Compare
shuangkun
changed the title
| } | ||
| err = we.RemoveFinalizer(ctx, common.FinalizerTaskResultStatus) |
There was a problem hiding this comment.
The executor removes the new /taskresult finalizer here after the WorkflowTaskResult has been updated. If the executor is interrupted before this point is reached, will the finalizer ever be removed? As far as I understand, the controller does not currently do anything with it.
If the controller were to remove the finalizer, it would also need to make sure that the associated WorkflowTaskResult is left in an appropriate state, as the executor is not guaranteed to have done so.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add a finalizer , prevent pod from being deleted before workflow taskresult complete.
Fixes #12993
Motivation
Modifications
Verification