-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the host of AWS Code Commit changeable #24771
Conversation
Changed Packages
|
Thanks for the contribution! |
Signed-off-by: SangKyu Kang <kang3498@hanmail.net>
Signed-off-by: SangKyu Kang <kang3498@hanmail.net>
@Kang3498 I did the same as you did and allowed the user to be able to set the host manually. Since I require the region, I am not adding a default entry in |
@stijnbrouwers No matter what method we use, we need to merge quickly to use Code Commit. Currently, we are not at the level where we can say that Code Commit is supported... |
This will be replaced with the PR #24843 |
Uffizzi Cluster |
Hey, I just made a Pull Request!
As-Is : The catalog:register action does not work when using AWS Code Commit.
In the link below, config.host is forced to console.aws.amazon.com, so, If I set repoContentsUrl to {region}.console.aws.amazon.com in the catalog:register action, No Integration error occurs.
https://github.com/backstage/backstage/blob/master/packages/integration/src/awsCodeCommit/config.ts#L67
Instead, if I remove the region from the url, an error occurs due to the link below.
https://github.com/backstage/backstage/blob/master/packages/backend-common/src/reading/AwsCodeCommitUrlReader.ts#L70
✔️ Checklist
Signed-off-by
line in the message. (more info)