core-*-api: backport support for external route ref default targets + config route binding #24777
+525
−116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd route binding through config Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
…ets and route binding through config Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Merged
5 tasks
github-actions
bot
added
documentation
Missing ChangesetsThe following package(s) are changed by this PR but do not have a changeset:
See CONTRIBUTING.md for more information about how to add changesets. Changed Packages
|
|
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
freben
reviewed
May 30, 2024
| routeValidationError = error; | ||
| throw error; | ||
| } | ||
| } else if (routeValidationError) { |
There was a problem hiding this comment.
This structure kinda assumes that resolveRouteBindings never throws. Could have the if (routeValidationError) check at the very top instead, and then a try/catch around both resolveRouteBindings and the validation. Or do you want this to potentially retry over and over if the resolutions failed the first time?
| return undefined; | ||
| }, | ||
| // This might already be implemented in the legacy ref, but we override it just to be sure | ||
| getDefaultTarget: newRef.getDefaultTarget, |
There was a problem hiding this comment.
Suggested change
| getDefaultTarget: newRef.getDefaultTarget, | |
| getDefaultTarget: newRef.getDefaultTarget?.bind(newRef), |
or is that paranoid? :D
acierto
approved these changes
May 31, 2024
Co-authored-by: Fredrik Adelöw <freben@gmail.com> Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
The new frontend system supports route binding through static configuration, for example:
It also lets you define default targets for external route references, for example:
This adds support for both of these features in the existing frontend system.
✔️ Checklist
Signed-off-byline in the message. (more info)