Patch release of #24792, #24779 #24797
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: blam <ben@blam.sh>
Signed-off-by: blam <ben@blam.sh>
Signed-off-by: blam <ben@blam.sh>
github-actions
bot
added
the
area:scaffolder
freben
approved these changes
May 15, 2024
acierto
reviewed
May 15, 2024
| format: format(replace)(), | ||
| format: format((obj: TransformableInfo) => { | ||
| if (!redactionPattern || !obj) { | ||
| return obj; |
There was a problem hiding this comment.
Wouldn't it be better to use here undefined?
Though it's kinda the same, it's easier to read the code faster
There was a problem hiding this comment.
You mean as the return value? We'd want to return obj if we don't have a redaction pattern
acierto
approved these changes
May 15, 2024
Rugvip
approved these changes
May 16, 2024
| format: format(replace)(), | ||
| format: format((obj: TransformableInfo) => { | ||
| if (!redactionPattern || !obj) { | ||
| return obj; |
There was a problem hiding this comment.
You mean as the return value? We'd want to return obj if we don't have a redaction pattern
|
Replaced by #24807 |
|
Uffizzi Cluster |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This release fixes an issue where the logger would crash on logging because of cyclical structures in the meta fields, also fixes an issue with external config schemas in the
app-backendplugin which was previously broken.