Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change owner to project for azure host #24798

Merged
merged 1 commit into from
May 20, 2024
Merged

Change owner to project for azure host #24798

merged 1 commit into from
May 20, 2024

Conversation

vinisdl
Copy link
Contributor

@vinisdl vinisdl commented May 15, 2024

Hey, I just made a Pull Request!

Adjusting the Owner text for Project to maintain the naming standard of Azure and the plugin itself, as in this commit [08c7d24]

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@vinisdl vinisdl requested review from a team as code owners May 15, 2024 17:43
@github-actions github-actions bot added the area:scaffolder Everything and all things related to the scaffolder project area label May 15, 2024
@backstage-goalie
Copy link
Contributor

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage/plugin-scaffolder plugins/scaffolder patch v1.20.0

@backstage-goalie
Copy link
Contributor

Thanks for the contribution!
All commits need to be DCO signed before they are reviewed. Please refer to the the DCO section in CONTRIBUTING.md or the DCO status for more info.

@vinisdl vinisdl force-pushed the repo-url-picker-azure-project branch from a532b1f to 612a453 Compare May 15, 2024 17:50
@vinisdl
change owner to project for azure host
612a453 
Signed-off-by: vinisdl <vinisdl@hotmail.com>
benjdlambert
benjdlambert approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@benjdlambert benjdlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thanks! 🎉 I thought this was a breaking change when I looked at this last friday, but I don't think it is, as the AzureRepoPicker isn't exported separately. Let's go with this! 🙏

@benjdlambert benjdlambert merged commit aa2ccc0 into backstage:master May 20, 2024
29 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Thank you for contributing to Backstage! The changes in this pull request will be part of the 1.28.0 release, scheduled for Tue, 18 Jun 2024.

@github-actions GitHub Actions
Copy link
Contributor

Uffizzi Cluster pr-24798 was deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjdlambert benjdlambert benjdlambert approved these changes

@vinzscam vinzscam Awaiting requested review from vinzscam vinzscam is a code owner automatically assigned from backstage/reviewers

Assignees
No one assigned
Labels
area:scaffolder Everything and all things related to the scaffolder project area
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vinisdl @benjdlambert