Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update setup-opentelemetry.md #24800

Merged
merged 1 commit into from
May 16, 2024
Merged

Update setup-opentelemetry.md #24800

merged 1 commit into from
May 16, 2024

Conversation

jaeeunl
Copy link
Contributor

@jaeeunl jaeeunl commented May 15, 2024 •
edited

Hey, I just made a Pull Request!

Updated the OpenTelemetry tutorial documentation to correct the production setup instruction.

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@github-actions github-actions bot added the documentation Improvements or additions to documentation label May 15, 2024
@jaeeunl
Update setup-opentelemetry.md
6e9f4d4 
Signed-off-by: Jaeeun Lee <jaeeunl@adobe.com>
@jaeeunl jaeeunl force-pushed the docs-update-production-setup-instruction-in-otel-tutorial branch from 3801dd6 to 6e9f4d4 Compare May 15, 2024 21:08
@jaeeunl jaeeunl marked this pull request as ready for review May 15, 2024 21:10
@jaeeunl jaeeunl requested review from a team as code owners May 15, 2024 21:10
Rugvip
Rugvip approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@Rugvip Rugvip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense, thank you! 👍

👀 @freben in you wanna double check

@Rugvip Rugvip merged commit 389ae5a into backstage:master May 16, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rugvip Rugvip Rugvip approved these changes

@benjdlambert benjdlambert Awaiting requested review from benjdlambert benjdlambert is a code owner automatically assigned from backstage/maintainers

@vinzscam vinzscam Awaiting requested review from vinzscam vinzscam is a code owner automatically assigned from backstage/reviewers

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jaeeunl @Rugvip