Skip to content

Commit

Permalink
Return to 1.2.3 portamento behavior
Browse files Browse the repository at this point in the history
Partly reverting the change we made addressing surge-synthesizer#7301, we change
the attempt-to-make-mono-fp-with-long-porta work fix, since it
ran away and didn't fix many cases.
  • Loading branch information
baconpaul committed Nov 22, 2023
1 parent 4bf58e4 commit 6be41a6
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions src/common/SurgeSynthesizer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -961,10 +961,13 @@ void SurgeSynthesizer::playVoice(int scene, char channel, char key, char velocit

if (wasGated && pkeyToReuse > 0)
{
// This is commented out since it runs away in some
// cases. It is an attempt to fix #7301

// In this case we want to continue the preivously
// initiated porta
nvoice->state.pkey = pkeyToReuse;
nvoice->state.portaphase = 1 - pphaseToReuse;
// nvoice->state.pkey = pkeyToReuse;
// nvoice->state.portaphase = 1 - pphaseToReuse;
}
}
}
Expand Down

0 comments on commit 6be41a6

Please sign in to comment.