fix(cloud-client): consider httpcore timeout when getting status #4740
+28
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For more information, see https://pre-commit.ci
frostming
reviewed
May 24, 2024
| @@ -487,10 +487,27 @@ def wait_until_ready( | |||
| spinner: Spinner | None = None, | |||
| spinner_task_id: TaskID | None = None, | |||
| ) -> None: | |||
| from httpcore import TimeoutException | |||
There was a problem hiding this comment.
why httpcore instead of httpx.Timeout?
There was a problem hiding this comment.
we should use from httpx, since httpcore is considered internal :)
There was a problem hiding this comment.
Um, the issue that was faced before actually arise from httpcore. Should we cover this case?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR address?
Fixes #(issue)
Before submitting:
guide on how to create a pull request.
pre-commit run -ascript has passed (instructions)?those accordingly? Here are documentation guidelines and tips on writting docs.