-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP feat: make messenger and protocol inits standalone #3835
Draft
moul
wants to merge
18
commits into
berty:master
Choose a base branch
from
moul:dev/moul/async-messenger-init
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
moul
changed the title
feat: make messenger and protocol inits standalone
WIP feat: make messenger and protocol inits standalone
Dec 30, 2021
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
n0izn0iz
reviewed
Mar 7, 2022
Comment on lines
-115
to
120
func NewService(opts *Options) (_ Service, err error) { | ||
func NewService(opts *Options) (Service, error) { | ||
rootCtx, rootCancelCtx := context.WithCancel(context.Background()) | ||
|
||
var s *service | ||
var ( | ||
s *service | ||
err error | ||
) | ||
endSection := tyber.SimpleSection(rootCtx, opts.Logger, "Initializing AccountService") | ||
defer func() { endSection(err, tyber.WithDetail("RootDir", s.rootdir)) }() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removing the named return will prevent tyber from catching the correct error
with the named return, a return nil, someErr
will set the named return to someErr
before executing the defer
s
that's also why we need to wrap the endSection
call in a lambda
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenAccount
(sync) and renameOpenAccountWithProgress
intoOpenAccount
CloseAccount
(sync) and renameCloseAccountWithProgress
intoCloseAccount
OpenAccount
into a newOpenProtocol
endpointCloseAccount
into a newCloseProtocol
endpointNetworkConfig
message definition fromBertyAccounts
toBertyMessenger
errcode.ErrCode
s to manage new cases—-
Note: I considered moving all the
NetworkConfig*
stuff fromBertyAccount
toBertyMessenger
, but the changes were too big and risky, I prefer to let the JS team refactor this part later, ideally when refactoring the onboardingMy suggestion ->
create/import/open account
are instant, then, you load the config and decide if you want to ask new prompts (i.e., BLE permission etc), then only you callOpenProtocol
with the appropriate configuration